crytic/slither

Improve 1346 to make it more efficient

Open

#1,570 opened on Jan 9, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (886 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,769 stars)
PR merge metrics
 (Avg merge 54d 9h) (2 merged PRs in 30d)

Description

https://github.com/crytic/slither/pull/1346 is a nice addition, which gives us fundamental features to do structure packing optimisations.

However it has a couple of drawback. For example packing storage variables might lead to more costly execution because of the additional opcode cost.

We could improve the detector to add a couple of heuristics. One example that comes to mind is to use https://eips.ethereum.org/EIPS/eip-2929#sstore-changes, and to pack together variables that are read within the same transaction.

We could make it a tool instead of a detector, and propose different scenario as a result, ie:

  • To optimize the run of contract.function1 pack together ..
  • To optimize the run of contract.function2 pack together ..

Having a tool would allow us additional fine tuning and flags.

Contributor guide

Research direction
Study the storage layout and gas costs in Solidity. Analyze the current detector PR #1346 and the EIP 2929 to understand which variables are accessed together. Design heuristics to suggest packing configurations that optimize gas for specific functions. Consider converting the detector into a tool that outputs multiple packing scenarios.
Tech stack
python
Domain
blockchainsecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SolidityPythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65