Typo in mem-cache dupe?

Open Beginner friendly
#144 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
tooling

Research direction

Open mixins/mem-cache.js at line 41 via the linked revision and inspect how type and value are used in the length check. Confirm the intended variable from the surrounding cache logic, then verify the corrected behavior with the repository’s available checks; the issue is done when the check examines the appropriate value.

Written by the indexing model from the issue text.

Description

This line checks the length of type which is always "blob" in this context. Likely it meant to check the length of value?

https://github.com/creationix/js-git/blob/81321539d3a3d82c5046d683d8f77853fb63453a/mixins/mem-cache.js#L41

Dominant language
JavaScript
Stars
3.8k
Forks
262
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from creationix/js-git

All issues in creationix/js-git

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.