coreybutler/node-windows

Service stopped unexpectedly but child node process doesn't

Open

#235 opened on Apr 17, 2019

View on GitHub
 (5 comments) (6 reactions) (0 assignees)JavaScript (367 forks)github user discovery
help wanted

Repository metrics

Stars
 (2,931 stars)
PR merge metrics
 (PR metrics pending)

Description

Once about every 2 months my node windows service crashes unexpectedly, usually at night so it's unlikely to be caused by load. When the service stopped, the child node process continues to run so the web service is not down. This issue is related to #12 except that service crashing unexpectedly is my main concern. Surviving child node process is also nagging because if child process is not killed before service is restarted there is port conflict.

Contributor guide

Research direction
Inspect the service wrapper code in node windows to find why the parent process exits without killing the child. Look for event handlers for uncaught exceptions or system signals. Ensure the child process is terminated when the parent crashes.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Node.jsWindows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50