corejavascript/typeahead.js

Travis Not running Browser tests

Open

#20 opened on Oct 16, 2015

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (956 stars) (232 forks)batch import
bughelp wanted

Description

Hi, of the 12 jobs running upon every Pull-request commit, none of the browser specific tests run!

Only the unit-test runs.

For example on #18, the tests ran, but only travis build 26.1 actually ran the test suite.

The others (browser based) had the following line in the output:

Not running any tests

which you can see for instance in travis build 26.2 and all the others in the travis build list for #18.

The line in test/ci https://github.com/corejavascript/typeahead.js/blob/master/test/ci#L5

elif [ "$TRAVIS_SECURE_ENV_VARS" == "true" -a "$TEST_SUITE" == "integration" ]; then

evaluates to

+'[' false == true -a integration == integration ']'

which must mean that "$TRAVIS_SECURE_ENV_VARS" is not set.

Who can help setting up the browser tests again?? I'd like to help but am in doubt about who has access to setting it up?

Contributor guide

Tech stack
javascript
Domain
devopstesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Travis CI configurationbash scriptingrepository admin access
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the test/ci script and the Travis CI configuration. The issue is that $TRAVIS SECURE ENV VARS is not set to true for pull requests from forks, causing the browser tests to be skipped. Check Travis CI documentation on secure environment variables and consider whether the repository requires admin intervention to set them. Look into alternative approaches that do not rely on secure vars.