corejavascript/typeahead.js

autocomplete() should trigger autocomplete event even when text already matches

Open

#132 opened on Mar 15, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (956 stars) (232 forks)batch import
enhancementhelp wanted

Description

Currently, autocomplete() doesn't trigger the autocomplete event if the input text matches the given $selectable. Why should it, if autocompletion won't change the text?

Because there may be other data attached to the typeahead choice which is extracted by downstream logic listening for the event.

Instead of

      isValid = data && query !== data.val;
      if (isValid && !this.eventBus.before('autocomplete', data.obj, data.dataset)) {

it should be just

      if (data && !this.eventBus.before('autocomplete', data.obj, data.dataset)) {

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptEvent systemTypeahead library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Review the autocomplete() method in src/typeahead/typeahead.js around line 371. Understand the current condition that prevents event dispatch when query matches. Implement the suggested change to remove the query !== data.val check. Ensure that the autocomplete event is emitted even when text matches, so that downstream listeners can access the data object.