copy/v86

Support changing 9p mount tag at runtime

Open

#678 opened on Jun 8, 2022

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Rust (19,458 stars) (1,353 forks)batch import
enhancementgood first issue

Description

It would be helpful to be able to change the name of the 9p file share. https://github.com/copy/v86/blob/4eb1e5035e91490c5aeebab45553d5043cd84b95/lib/9p.js#L82

For dynamically generating mount tags:

/**
 * @param {string} mountTagName
 */
function genMountTagArray(mountTagName) {
    /**
     * @type {Number[]}
     */
    let _mountTagArray;
    Array.from(mountTagName).forEach(function(char) {
        _mountTagArray.push(char.charCodeAt(0));
    });
    return _mountTagArray;
};

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript9p protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the current implementation at lib/9p.js line 82 where the mount tag is set statically. Implement a function to allow dynamic updates, possibly by storing the tag in a variable and adding a setter. Ensure the change is applied to the 9p filesystem. Review comments in the issue for any proposed API designs.