containers/podman

Manifests: No tests for doing API manifests/imagename&images=foo

Open

#22,258 opened on Apr 4, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (3,107 forks)batch import
ContribfestGood First Issuekind/bugvolunteers-wanted

Repository metrics

Stars
 (31,686 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description

I noticed that in the documentation, we can pass in 'images' to the libpod/manifests/foobar?images=foo endpoint.

However, I noticed we have no tests for this? https://github.com/containers/podman/blob/main/test/apiv2/15-manifest.at

Also, we can actually create a manifest without images... even though the documentation says otherwise (shows required): https://docs.podman.io/en/latest/_static/api.html#tag/manifests/operation/ManifestCreateLibpod

Steps to reproduce the issue

N/A see https://github.com/containers/podman/blob/main/test/apiv2/15-manifest.at missing tests

Describe the results you received

N/A, missing tests.

Describe the results you expected

Tests for ?images parameter to manifests

podman info output

N/A

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

Contributor guide

Research direction
Write tests for the manifests API endpoint with the images parameter in the test file test/apiv2/15 manifest.at.
Tech stack
goshell
Domain
backendapi
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoBash
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70