[Bug]: TypeScript typecheck fails in PlayOnScroll and CommunityMeetingsCardGrid
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start with src/components/utilities/PlayOnScroll/index.tsx and src/components/layout/CommunityMeetingsCardGrid/index.tsx, then run yarn typecheck to reproduce the reported errors. Check the usage in src/pages/features.tsx and the markdown child handling, and consider the issue complete when both components typecheck without breaking community meeting URL parsing.
Written by the indexing model from the issue text.
Description
yarn typecheck at the moment doesn't pass due to TypeScript errors in two components.
- PlayOnScroll
File:
src/components/utilities/PlayOnScroll/index.tsx
PlayOnScroll is defined as React.FC instead of using the current VideoProps type. This leads TypeScript to assume that the component does not take any props.
It results in the following errors in:
src/pages/features.tsx
for vidFormat, url, posterImg, and styles.
- CommunityMeetingsCardGrid
File:
src/components/layout/CommunityMeetingsCardGrid/index.tsx
The logic for rendering markdown tries to access child.props after typing child as object. TypeScript complains that there is no props property on type object.
It breaks the parsing logic for extracting community meeting recording URLs.
Both problems block the repository from passing yarn typecheck
LLM Policy
- This issue is human-written, and folow up comments will also be human-written
- Dominant language
- TypeScript
- Stars
- 108
- Forks
- 188
- Avg merge
- 3d 14h
- Merged PRs (30d)
- 11
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from containers/podman.io
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
containers/podman.io#727 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
containers/podman.io#725 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
containers/podman.io#696 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
containers/podman.io#692 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
containers/podman.io#686 · 1 comment ·
All issues in containers/podman.io
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100