connorferster/forallpeople

Replace remaining stubs in test_forallpeople.py with proper tests

Open

#2 opened on Apr 19, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (50 forks)github user discovery
good first issue

Repository metrics

Stars
 (376 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There are some unit tests in test_forallpeople.py that are still sitting with stubs that are written as return True (bad on me!) Almost all of the functions in the module have tests but there are functions that have tests that are just stubs. Unit tests need to replace the stubs.

Contributor guide

Research direction
Examine the stubbed functions in test forallpeople.py and replace each 'return True' with proper assertions that test the actual function behavior.
Tech stack
python
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonunit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80