confluentinc/ksql

KsqlTesterTest coverage for partition/offset

Open

#8,194 opened on Sep 29, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (5,739 stars) (1,048 forks)batch import
enhancementgood first issuestreaming-enginetest-coverage

Description

Is your feature request related to a problem? Please describe. When trying to develop tests for the new pseudocolumns ROWPARTITION and ROWOFFSET, which represent the partition and offset of the record, respectively, I found that the returned partition and offset were always equal to 0.

Describe the solution you'd like The spoofed kafka topic to include support for partition and offset- QTTs don't do this perfectly (see https://github.com/confluentinc/ksql/issues/7982) , but they provide enough support for most use cases.

Describe alternatives you've considered Adding testing without coverage for partition/offset values. This is probably fine for now but can be improved upon.

Contributor guide

Tech stack
java
Domain
testingbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of KafkaJava programmingFamiliarity with JUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the existing KsqlTesterTest infrastructure and refer to issue #7982 for context on how partition and offset are handled in Kafka test tools. The goal is to extend the spoofed Kafka topic to support non zero partition/offset values. Look at the linked PR in #7982 and the test classes to identify where changes can be made.
KsqlTesterTest coverage for partition/offset · confluentinc/ksql#8194 | Good First Issue