confluentinc/ksql

Improve "exhausted standby hosts to try" Error Message

Open

#8,136 opened on Sep 15, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (1,048 forks)batch import
fix-it-weekgood first issuequery-engine

Repository metrics

Stars
 (5,739 stars)
PR merge metrics
 (Avg merge 4d 20h) (6 merged PRs in 30d)

Description

Similarly to https://github.com/confluentinc/ksql/issues/7772, this error message is not super helpful to understand what's going on:

https://github.com/confluentinc/ksql/blob/1a1297ab59db0af416a924d4135b93dcc5003561/ksqldb-engine/src/main/java/io/confluent/ksql/physical/pull/HARouting.java#L244-L246

We should include more information to help expose what's going on, such as which partitions failed and which hosts were attempted.

Contributor guide

Research direction
Inspect the error message in HARouting.java around line 244. Identify which partitions are failing and which hosts have been attempted. Then update the error message to include this information.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70