Cannot update workflow without accessing deprecated methods

Open
#95 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
api

Research direction

Start with MetadataClient.registerWorkflowDef(workflow, true) and compare its behavior with the direct client.metadataResource.update workaround. Check the POST /api/metadata/workflow request and determine whether MetadataClient can update without the deprecated method or whether overwrite support is needed; done means workflow updates succeed without a deprecation warning.

Written by the indexing model from the issue text.

Description

When trying to update a workflow using MetadataClient.registerWorkflowDef(workflow, true) with the latest build of conductor-oss, the request fails. It looks as though the Orkes implementation of POST /api/metadata/workflow supports an overwrite query param, but the Conductor OSS build doesn't.

The current way around this is to call client.metadataResource.update directly, but this results in a deprecation warning. While this is currently functional, it'd be great if there was a way to update directly using MetadataClient OR I suppose adding overwrite support to the Conductor OSS build would also do the trick.

Thanks!

Dominant language
TypeScript
Stars
58
Forks
20
Avg merge
1d 13h
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from conductor-oss/javascript-sdk

All issues in conductor-oss/javascript-sdk

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.