con2/kompassi

Add pattern validation to slug fields

Open

#401 opened on Feb 1, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (31 forks)auto 404
good first issuetypescript

Repository metrics

Stars
 (29 stars)
PR merge metrics
 (PR metrics pending)

Description

At least in

  • survey slugs (dash)
  • dimension slugs (underscore)
  • dimension value slugs (underscore)
  • form field slugs

Currently this is the validator used in backend:

https://github.com/con2/kompassi/blob/69c3418ab4da651f6eab9c2890c60076b29f7623/backend/core/utils/model_utils.py#L9-L12

However, this is not validated on the forms, causing a GraphQL error and #399.

Add a similar pattern validator in the frontend to the inputs that convey slugs.

Also the backend validator is shit and does substring match or something else that is fucked up. For example ooh-tukilomake including the space is a valid survey slug according.

Contributor guide

Research direction
Examine the existing backend validator in model utils.py and identify the pattern validation logic. Then locate the frontend slug input components and implement a similar pattern validation using a library or custom function.
Tech stack
pythonjavascript
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PythonJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65