Check errno after calling strtol
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Locate the strtol calls involved in parsing numeric input and inspect how errno is handled after conversion. The change is complete when invalid and out-of-range numbers are detected reliably; use the repository's relevant parser tests if available to verify those cases.
Written by the indexing model from the issue text.
Description
Unrelated, but you have to check errno after calling strtol to detect invalid and out-of-range numbers reliably.
Originally posted by @nwellnhof in https://github.com/commonmark/cmark/issues/613#issuecomment-4553181190
- Dominant language
- C
- Stars
- 2k
- Forks
- 691
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from commonmark/cmark
-
Incorrect `parser->offset` advancement for closing fenced code blocks in `parse_code_block_prefix` Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
commonmark/cmark#590 · 3 comments ·
-
API documentation is missing an explanation of CMARK_NODE_CUSTOM_BLOCK and CMARK_NODE_CUSTOM_INLINE Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
commonmark/cmark#441 · 2 comments ·
-
Inline code language Open
Difficulty 4/5 3-5 days Newbie friendliness 52/100
commonmark/cmark#626 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
commonmark/cmark#624 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
commonmark/cmark#618 ·
All issues in commonmark/cmark
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·