commandlineparser/commandline

DateOnly not supported

Open

#855 opened on Oct 19, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,280 stars) (461 forks)batch import
help wanted

Description

The DateOnly data type causes a NotSupportedException to be thrown when calling ParseArguments.

v2.9.1 from Nuget.

public class CommandLineOptions
  {
      [Option('v', "verbose", Required = false, HelpText = "Set output to verbose messages.")]
      public bool Verbose { get; set; }

      [Option('d', "business-date", Required = true, HelpText = "The date (yyyy-mm-dd) to run the process for.")]
      public DateTime Works { get; set; }

      [Option('e', "run-date", Required = true, HelpText = "The date (yyyy-mm-dd) to run the process for.")]
      public DateOnly Fails { get; set; }
  }

Workaround: Use DateTime instead and do an explicit conversion when property is used DateOnly.FromDateTime(value);

Contributor guide

Tech stack
csharp
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#.NETcommandlineparser library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue reports that `DateOnly` causes a `NotSupportedException` when `ParseArguments` is called. To fix, find where supported types are enumerated or converted in the source code. Likely files: `CommandLineParser.cs` or `TypeConverter.cs`. Add `DateOnly` to the list of supported types, implementing parsing from string. Check for existing similar implementations like `DateTime` to model the conversion. The workaround uses `DateTime`, so follow the same pattern.