[Bug] DISABLE_CDP_ERROR_REPORTING and DISABLE_CDP_USAGE_TRACKING require both env vars set to disable analytics

Open Beginner friendly

#773 opened on Aug 5, 2026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 1/5
Estimated time: Under an hour
Newbie friendliness: 88/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Quiet
Tech stack: python
Domain: backend

Research direction

Start in python/cdp/cdp_client.py at the analytics enable condition shown in the issue, and inspect how the two environment variables are evaluated. Done means each disable variable works independently and both together prevent analytics setup; verify the combinations described in the issue.

Written by the indexing model from the issue text.

Description

Summary

In python/cdp/cdp_client.py, the analytics enable condition uses or instead of and, meaning you must set both env vars to disable analytics. Setting only one has no effect.

Affected Code

# python/cdp/cdp_client.py
if api_key_id and (
    os.getenv("DISABLE_CDP_ERROR_REPORTING") != "true"
    or os.getenv("DISABLE_CDP_USAGE_TRACKING") != "true"  # ← should be `and`
):
    Analytics["identifier"] = api_key_id

Current (broken) behavior

DISABLE_CDP_ERROR_REPORTING=true alone → analytics still active (or short-circuits to True)
Both env vars must be "true" to disable analytics

Expected behavior

Setting either env var to "true" should disable that feature; setting both should disable both.

Fix

if api_key_id and (
    os.getenv("DISABLE_CDP_ERROR_REPORTING") != "true"
    and os.getenv("DISABLE_CDP_USAGE_TRACKING") != "true"
):
    Analytics["identifier"] = api_key_id

Dominant language: Python
Stars: 200
Forks: 191
Avg merge: 3h 52m
Merged PRs (30d): 13

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[BUG] GkeTpuCluster queries metadata.google.internal for MEGASCALE_SLICE_ID even when TPU_SKIP_MDS_QUERY is set Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

jax-ml/jax#40854 · Opened Sep 22, 2026
[pcied] Honour PCIE_DETACH_INFO on platforms that are not smartswitches Open

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

sonic-net/sonic-platform-daemons#900 · Opened Sep 21, 2026
MCP client has no httpx timeout, so the event stream fails after 5 seconds Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

Azure/azure-functions-agents-runtime#228 · Opened Sep 21, 2026
feat(mcp): friendlier error when `run_cloud_sync` is called on a disabled connection Open

enhancement

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

airbytehq/PyAirbyte#1205 · Opened Sep 21, 2026
pn7160: reader goes permanently deaf — post-read IRQ-low check fails reads that succeeded Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

esphome/esphome#19452 · Opened Sep 21, 2026

More Python issues