coil-kt/coil

Placeholder image messes up image `ContentScale`

Open

#2779 opened on Jan 7, 2025

View on GitHub
 (3 comments) (8 reactions) (0 assignees)Kotlin (11,779 stars) (757 forks)batch import
help wanted

Description

Describe the bug If i use placeholder then the final image does not have the correct contentScale or height, it stays the same height which the placeholder has

To Reproduce Run this code

With Placeholder

AsyncImage(
    model = "https://images.unsplash.com/photo-1595757816291-ab4c1cba0fc2?fm=jpg&q=60&w=3000&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxzZWFyY2h8Mnx8cmVkJTIwYmFja2dyb3VuZHxlbnwwfHwwfHx8MA%3D%3D",
    modifier = Modifier.fillMaxWidth().padding(16.dp),
    contentScale = ContentScale.FillWidth,
    placeholder = painterResource(Res.drawable.placeholder_large),
    contentDescription = "Image"
)

Expected

Achieved by removing the placeholder

AsyncImage(
    model = "https://images.unsplash.com/photo-1595757816291-ab4c1cba0fc2?fm=jpg&q=60&w=3000&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxzZWFyY2h8Mnx8cmVkJTIwYmFja2dyb3VuZHxlbnwwfHwwfHx8MA%3D%3D",
    modifier = Modifier.fillMaxWidth().padding(16.dp),
    contentScale = ContentScale.FillWidth,
    contentDescription = "Image"
)

Version 3.0.4

Contributor guide

Tech stack
kotlinandroid
Domain
frontendmobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
KotlinJetpack Compose basicsCoil library familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how the placeholder's intrinsic size affects the image's content scale in AsyncImage. Look at the implementation in the coil compose module, specifically the AsyncImage composable and its handling of painterResource and contentScale. Check if the placeholder's dimensions override the content scale after the actual image loads. Consider reviewing recent commits related to content scale handling.