codex-team/editor.js

`inlineToolbar` always show convertTo, inconsist behavior with config value, and cannot be removed

Open

#2,833 opened on Sep 29, 2024

View on GitHub
 (4 comments) (1 reaction) (0 assignees)TypeScript (1,985 forks)batch import
buggood first issue

Repository metrics

Stars
 (26,602 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe a bug.

const editor = new EditorJS({
  holder: 'editor',
  tools: {
    paragraph: {
      // built-in inline tools: link, bold, italic
      // disable inline tools: false,
      inlineToolbar: ['bold', 'link'],
    },
  },
})

Expected behavior:

convertTo should also follow inlineToolbar config, which control it show or hide.

Screenshots:

image

As you see, it even show when no convertor available.

Device, Browser, OS:

Editor.js version:

Plugins you use with their versions:

Contributor guide

Research direction
Investigate the inlineToolbar configuration handling in Editor.js, specifically how the convertTo option is shown regardless of inlineToolbar settings. Trace the code path that renders the inline toolbar.
Tech stack
typescriptjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60