codex-team/editor.js

Bug: clicking outside of an editor should clear currentBlock (call dropPointer) even if selection was inside of editor before the click

Open

#2,643 opened on Feb 29, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (1,985 forks)batch import
buggood first issue

Repository metrics

Stars
 (26,602 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe a bug.

Steps to reproduce:

  1. Go to example_dev.html
  2. Click on somewhere outside of the editor
  3. Press '/'

Expected behavior: Toolbox shouldn't be opened, because I've already went out of the editor by clicking outside

Actual: Toolbox is still opened because we haven't cleared currentBlock

Device, Browser, OS: Any

Editor.js version: 2.29.1

Contributor guide

Research direction
Investigate the click event handling in the editor to ensure that clicking outside triggers dropPointer and clears currentBlock. Look at the 'currentBlock' property and the 'dropPointer' method.
Tech stack
typescriptjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75