codex-team/editor.js

Bug: clicking outside of an editor should clear currentBlock (call dropPointer) even if selection was inside of editor before the click

Open

#2,643 opened on Feb 29, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (26,602 stars) (1,985 forks)batch import
buggood first issue

Description

Describe a bug.

Steps to reproduce:

  1. Go to example_dev.html
  2. Click on somewhere outside of the editor
  3. Press '/'

Expected behavior: Toolbox shouldn't be opened, because I've already went out of the editor by clicking outside

Actual: Toolbox is still opened because we haven't cleared currentBlock

Device, Browser, OS: Any

Editor.js version: 2.29.1

Contributor guide

Tech stack
typescriptjavascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of DOM eventsfamiliarity with block style editors
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug is that clicking outside the editor does not clear currentBlock, causing the toolbox to open unexpectedly. Look at the editor's click event handlers, likely in the core module (e.g., core.js or similar). The fix likely involves adding a document click listener that calls dropPointer() when clicking outside the editor area. Check if there are any existing event listeners that handle outside clicks and ensure they properly reset currentBlock.