codex-team/editor.js

An empty block is added in readOnly mode on top

Open

#2,613 opened on Feb 12, 2024

View on GitHub
 (3 comments) (6 reactions) (0 assignees)TypeScript (26,602 stars) (1,985 forks)batch import
almost donebuggood first issue

Description

After the update to 2.29.0 in readonly mode there is a empty block added with an invisible (opacity: 0) placeholder text. The empty line is breaking the layout.

I temporarily fixed it with CSS:

.ce-paragraph[data-placeholder][contenteditable="false"]:empty {
  display: none;
}

Expected behavior: No additional line on top should be rendered, like in v2.28.0 in readOnly mode.

Screenshots: image

Device, Browser, OS: Macbook, Chrome, MacOS

Editor.js version: 2.29.0

Contributor guide

Tech stack
typescripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSJavaScriptEditor.js basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the changes between versions 2.28.0 and 2.29.0 that introduced this behavior. Look at the Paragraph block tool's CSS and the read only mode rendering logic in the core editor. The workaround suggests adjusting CSS for empty paragraphs in contenteditable=false. Check the components/Core or tools/paragraph directories.