codex-team/editor.js

Links should be clickable

Open

#2,526 opened on Nov 2, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (26,602 stars) (1,985 forks)batch import
good first issuenice to have

Description

If you select some text and add a link (using the link icon, near bold and italic), then the text is displayed as a link, but clicking on the link, doesn't open the link.

It would be nice to have clickable links that open the target URL when they are clicked.

This is useful to verify if the inserted link works properly.

Contributor guide

Tech stack
typescriptjavascripthtmlcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptDOM event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine how links are currently rendered in Editor.js, likely in the inline tool for links (e.g., src/tools/inline/link.ts). Understand the existing rendering of anchor tags and add click event listeners to open the URL. Ensure that clicking does not interfere with block selection or other editor interactions. Use window.open() or a custom handler.