codex-team/editor.js

[Bug] Switching to readonly mode with an empty editor

Open

#1,702 opened on Jun 1, 2021

View on GitHub
 (2 comments) (2 reactions) (1 assignee)TypeScript (26,602 stars) (1,985 forks)batch import
buggood first issue

Description

Describe a bug. If you switch the editor to read-only mode after initialization, an error appears: System.Exception: Cannot read property 'holder' of undefined

togglePreviewVisibility(visible: boolean) {
		this._editor.readOnly.toggle(visible); // this._editor.blocks.getBlocksCount() === 0
		this.previewVisible = visible;
	}

Editor.js version: 2.22.0

Contributor guide

Tech stack
typescriptjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptEditor.js basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The error occurs when toggling read only mode with an empty editor (no blocks). The issue likely lies in the togglePreviewVisibility method or associated readOnly logic. Search for where 'holder' property is accessed and add a null check. Look at the code in editor.js related to readOnly toggle.