bug: MkdirAll uses 0o644 for feature directories (missing execute bit)
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
Research direction
Open devcontainer/devcontainer.go and inspect the two fs.MkdirAll calls that create the feature extraction directories. Change both directory permission masks to 0o755, then run the existing tests that cover feature extraction; done means the directories are traversable by non-root users on a real filesystem.
Written by the indexing model from the issue text.
Description
devcontainer/devcontainer.go calls fs.MkdirAll(featuresDir, 0o644) and fs.MkdirAll(featureDir, 0o644) when creating feature extraction directories. 0o644 is a file permission mask — directories need the execute bit (0o755) to be traversable by non-root users.
On the in-memory filesystem used in tests this is harmless, but on a real filesystem it could prevent non-root container users from accessing feature install scripts.
This pre-dates #500 (the feature ordering PR) — the same 0o644 was used in the original code.
Fix
Change both MkdirAll calls to use 0o755.
🤖 Written by a Coder Agent.
- Dominant language
- Go
- Stars
- 300
- Forks
- 64
- Avg merge
- 20m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coder/envbuilder
-
bug envbuilder needs-investigation
Difficulty 4/5 3-5 days Newbie friendliness 35/100
coder/envbuilder#495 ·
-
envbuilder Feature
Difficulty 3/5 1-2 days Newbie friendliness 56/100
coder/envbuilder#492 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
coder/envbuilder#484 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
coder/envbuilder#483 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
coder/envbuilder#481 · 1 comment ·
All issues in coder/envbuilder
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·