[Bug]: Failed to resolve the callback address of the identity verification plugin.

Open

#6,585 opened on Dec 13, 2023 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 25/100

Issue type: Bug
Clarity: Needs clarification
Activity status: Stale
Tech stack: typescript
Domain: authentication

Research direction

Start by reproducing the authentication callback parsing failure with code-server 4.19.1 and the reported identity verification plugin, then compare the encoded callback handling with VS Code, where authentication succeeds. The issue provides no file, test, logs, or complete reproduction steps; done means the plugin callback authenticates successfully without breaking other callback parameters.

Written by the indexing model from the issue text.

Description

bug

Is there an existing issue for this?

I have searched the existing issues

OS/Web Information

code-server --version: 4.19.1 0c98611e6b43803a9d5dba222d7023b569abfb49 with Code 1.84.2

Steps to Reproduce

Expected

authentication success

Actual

I have a personal authentication plugin. When the authentication is successful and it returns to vscode-server, there was a failure in parsing the callback address. All parameters of the callback address are encoded as a whole, but during parsing, the parameters are first obtained and then decoded, resulting in authentication failure for the callback.

Unable to duplicate lines in vscode, vscode authentication is normal.

Logs

No response

Screenshot/Video

468022d10f9915d76607cdedae457d19

Does this issue happen in VS Code or GitHub Codespaces?

I cannot reproduce this in VS Code.
I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over a secure context?

I am using a secure context.

Notes