codenotary/immudb

Small CLI fix on "discover absolute path"

Open

#632 opened on Jan 28, 2021

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Go (371 forks)auto 404
Component::immuadminenhancementgood first issue

Repository metrics

Stars
 (8,999 stars)
PR merge metrics
 (PR metrics pending)

Description

This requires just some small improvements, the error itself being harmless, but annoying.

$ immuadmin-090 login immudb
ERROR 2021/01/28 09:46:25 Couldn't discover absolute path
ERROR 2021/01/28 09:46:25 getwd: no such file or directory
Password:
logged in
$

immuadmin-090 is just a sym link:

$ which immuadmin-090
/home/{user}/apps/bin/immuadmin-090
$
$ ls -l `which immuadmin-090`
lrwxrwxrwx 1 {user} {group} 25 Jan 27 13:37 /home/{user}/apps/bin/immuadmin-090 -> ../immudb/0.9.0/immuadmin
$

However, this is happening even if the binary is called directly:

$ ~/apps/immudb/0.9.0/immuadmin status       
ERROR 2021/01/28 09:53:05 Couldn't discover absolute path
ERROR 2021/01/28 09:53:05 getwd: no such file or directory
OK - server is reachable and responding to queries
$

Contributor guide

Research direction
Investigate where 'getwd' is called in the CLI code, handle cases when the current working directory cannot be determined (e.g., symlink or deleted directory), and suppress or gracefully handle the error.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90