codeigniter4/CodeIgniter4

Dev: PHPStan "no type specified" errors

Open

#7,731 opened on Jul 22, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)PHP (4,492 stars) (1,707 forks)batch import
devgood first issuehelp wanted

Description

There are 473 ignored errors due to "no type specified" in phpstan-baseline.php. These ignored errors should be removed.

You can search for no type specified, no return type specified in phpstan-baseline.php.

Contributor guide

Tech stack
None
Domain
backenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHP programmingPHPStanType declarations in PHPReading phpstan baseline.php
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Look at phpstan baseline.php in the root of the repository, search for lines containing 'no type specified' or 'no return type specified'. For each such error, add proper type hints to the corresponding PHP file. The baseline file shows the file and line number of each error. Ensure that the type hints are correct and consistent with the codebase's style. The issue has 473 errors, so start with a few to understand the pattern.