codeigniter4/CodeIgniter4

Dev: replace type `mixed` with more specific types

Open

#6,310 opened on Jul 29, 2022

View on GitHub
 (11 comments) (0 reactions) (0 assignees)PHP (4,492 stars) (1,707 forks)batch import
devgood first issuehelp wanted

Description

Type mixed means object|resource|array|string|int|float|bool|null. https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.mixed

The current code base has a lot of type mixed in PHPDocs, But I think all of them are not correct.

And mixed prevents PHPStan level from increasing.

PHPStan’s rule level 6 isn’t satisfied with implicit mixed https://phpstan.org/writing-php-code/phpdoc-types#mixed

We need to replace type mixed with more specific types.

Contributor guide

Tech stack
None
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHP basicsunderstanding of PHPDoc type declarationsfamiliarity with PHPStan
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Search the codebase for occurrences of `mixed` in PHPDoc comments (e.g., using grep or an IDE). Replace each with the most specific type as per PHP documentation (e.g., `string`, `int`, `array`). Refer to PHPStan's rule level 6 expectations. No linked PRs or maintainer questions as of now.