codee-com/open-catalog

[Fortran] Replace `if (integer)` with `if (logical)`

Open

#38 opened on Sep 24, 2024

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Fortran (12 forks)auto 404
Fortrangood first issuenew check

Repository metrics

Stars
 (105 stars)
PR merge metrics
 (PR metrics pending)

Description

In Fortran there is no equivalence between logical and integer variables, so 0 is not a replacement for .false., and 1 does not replace .true.. Yet, some compilers (ifort) will happily compile if (1).

Example:

if (0) write(*, *) 'Test is false'
if (1) write(*, *) 'Test is true'

A slightly more meaningful example

integer val
val = 1
if (val) write(*, *) 'Test is true'

This should be replaced by

integer val
val = 1
if (val > 0) write(*, *) 'Test is true'

Contributor guide

Research direction
Identify all occurrences where an integer variable is used in a logical context inside if statements, and replace with appropriate logical expressions. For example, replace 'if (val)' with 'if (val > 0)' or similar.
Tech stack
None
Domain
documentation
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Fortran
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85