codeceptjs/CodeceptJS

[feature-request] REST helper rejectOnError config option

Open

#1,293 opened on Oct 30, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (725 forks)batch import
RESTenhancementgood first issue

Repository metrics

Stars
 (3,956 stars)
PR merge metrics
 (Avg merge 11d 16h) (21 merged PRs in 30d)

Description

Just that. How do you feel about a config option for the REST helper to make the promises reject whenever there is an error response, ex. status codes 4XX, 5XX, etc? (I personally think it should be the default behaviour)

I could create a pull request for this, as I have implemented it already on a custom helper on the project I'm working on.

Contributor guide

Research direction
Find the REST helper module in the CodeceptJS source code, understand its response handling, and implement a new config option to reject promises on 4xx/5xx status codes.
Tech stack
javascript
Domain
backendapitesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75