cockroachdb/cockroach

docgen: recognize "unimplemented" as marker to ignore rules

Open

#45464 opened on Feb 26, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (32,150 stars) (4,124 forks)batch import
A-docsC-enhancementE-easygood first issue

Description

Various aspects of our SQL grammar are marked as "unimplemented". These unimplemented features/keywords/etc. should not be included in the generated SQL diagrams we use in our docs. Currently, we must edit diagrams.go to hide unimplemented syntax from the generated bnfs that are used to genereate our SQL diagrams. Instead, it would be great if "unimplemented" were treated like /* SKIP DOC */. This would be much more efficient in that all unimplemented features would be excluded from all generated bnfs without docs writers needed to tweak diagrams.go.

Example: https://github.com/cockroachdb/cockroach/pull/45442

Jira issue: CRDB-5153

Contributor guide

Tech stack
gosql
Domain
documentation
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programminggrammar parsingdocgen tool
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the existing docgen code that processes grammar markers like 'SKIP DOC' (likely in a file like `cmd/docgen/main.go` or similar). The linked PR (#45442) may provide an example of similar changes. Implement logic to detect 'unimplemented' in the grammar and skip generating diagrams for those rules. Ensure the change is consistent with the current skipping mechanism.