cobrateam/splinter

add an alternative to find_by_text that looks at all inner text

Open

#862 opened on Mar 11, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (509 forks)auto 404
Docsgood first issue

Repository metrics

Stars
 (2,754 stars)
PR merge metrics
 (PR metrics pending)

Description

The current implementation of find_by_text uses the following xpath: //*[text()="some text"], which only looks at the first text node within an element. This makes it difficult to query for elements with text split across multiple text nodes.

I think it would be useful to add an alternative that acts more like element.textContent(), querying against all inner text of an element rather than its first text node. This can be done with the following xpath: //*[.="some text"]

It could be called find_by_text_content or find_by_inner_text or something along those lines.

I'm happy to do the implementation and make a pull request if people agree that there's a need / desire for this

Contributor guide

Research direction
Examine the current find by text implementation in the Splinter source code, understand the XPath `//*[text()="some text"]`, and create a new method using `//*[.="some text"]` to match all inner text. Implement the method and submit a pull request.
Tech stack
python
Domain
testingweb dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonXPath
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70