cobrateam/splinter

Finding partial text

Open

#608 opened on Apr 28, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (509 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (2,754 stars)
PR merge metrics
 (PR metrics pending)

Description

It is very common that you want to look for a snippet of text, rather than a text element that as a whole contains exactly what you look for; like when looking for a username on a page.

The current browser.is_text_present however only matches a text element 1:1. (and the documentation about this is not very clear that this is what is going on).

So if we have

<h1>Welcome, DeathSlayer!</h1>

Then browser.is_text_present("DeathSlayer") will return false, as will browser.is_text_present("Welcome, DeathSlayer") (because of the missing exclamation mark).

Could another command be introduced for this?

Contributor guide

Research direction
Locate the existing is text present method implementation and create a new method that uses substring matching (e.g., using Python's 'in' operator) instead of exact equality. Ensure the new method is documented and tested.
Tech stack
python
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75