filters plugin uses msg.frm.room which does not exist for DMs on Zulip
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
Research direction
Start in corobo/utils/filters.py at line 21 and trace how _process_command_filters in errbot/core.py passes direct messages into the filter. Check the ZulipPerson message shape and existing room-filter behavior. Done means direct messages no longer raise AttributeError while room-based filtering continues to work.
Written by the indexing model from the issue text.
Description
7dcc1e07 introduces filters. On Zulip, in direct messages, this causes
Traceback (most recent call last):
File "/.../errbot/errbot/core.py", line 345, in _process_command_filters
msg, cmd, args = cmd_filter(msg, cmd, args, dry_run)
File "/.../corobo/utils/filters.py", line 21, in filters
if cmd in commands and msg.frm.room.uri == room:
AttributeError: 'ZulipPerson' object has no attribute 'room'
- Dominant language
- Python
- Stars
- 67
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coala/corobo
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100