cmu-delphi/forecast-eval

Data downloading fails if score type is coverage or if summarizing across multiple locations

Open

#255 opened on Mar 31, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)R (3 forks)auto 404
good first issue

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (PR metrics pending)

Description

We see this error

Warning: Error in filter: Problem while computing `..1 = !is.na(Score) | target_end_date >= filterDate`.
Caused by error in `mask$eval_all_filter()`:
! argument "filterDate" is missing, with no default

filterOverAllLocations requires a filterDate arg, but when totaling across locations or looking at coverage scores, we don't pass filterOverAllLocations a filterDate.

createExportScoreDataFrame will need to be passed at least a date to use in the filter. The value should be dataCreationDate to match other score-generating logic.

Consider passing input$asOf as well and adding as-of data onto the exported dataframe, to more closely match what we're using in the plots.

Contributor guide

Research direction
Inspect the function filterOverAllLocations in data manipulation.R to add the missing filterDate argument, then update the call in exportScores.R to pass dataCreationDate. Also consider passing input$asOf to match plot logic.
Tech stack
r
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
gitr
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60