cmu-delphi/delphi-epidata

Write integration tests for src/acquisition/covidcast/database.py

Open

#896 opened on Apr 11, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (67 forks)auto 404
acquisitionhelp wantedtestsv4

Repository metrics

Stars
 (104 stars)
PR merge metrics
 (PR metrics pending)

Description

Integration tests because we do want to exercise the actual database engine here, and not a mock.

  • make sure is_latest_issue is being set correctly -
    • when adding new daily data (data in signal_load has > issue than data in signal_latest)
    • when uploading data patches (data in signal load has < issue than data in signal_latest)
  • make sure data is being correctly transferred from signal_load into signal_* and *_dim
    • make sure signal_latest is only overwritten when signal_load issue is >=
    • make sure rows are added to *_dim only when needed

+Any other corner cases that worry you.

Use integrations/acquisition/covidcast/test_*.py as templates.

Contributor guide

Research direction
Examine the existing integration tests in integrations/acquisition/covidcast/test *.py as templates. Understand the database schema and the logic for setting is latest issue in signal load and signal latest. Write tests that cover: inserting new daily data with higher issue, inserting data patches with lower issue, and ensuring signal latest is overwritten only when new issue is >=. Also test that rows in * dim are added only when needed.
Tech stack
python
Domain
backenddatabasetesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PythonpytestSQLAlchemyPostgreSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50