clutchski/coffeelint

add rule that if(!foo) should be replaced with unless

Open

#381 opened on Feb 18, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)CoffeeScript (1,203 stars) (169 forks)batch import
Help Wantednew rule

Description

basically - if you have an if block with no else, and you have if not or if !blah, it should be replaced with unless.

if !user
    return res.badRequest ...

should become

unless user
    return res.badRequest..

Contributor guide

Tech stack
None
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of CoffeeScriptfamiliarity with coffeelint's rule structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine existing rules in coffeelint, such as the 'no unnecessary double parens' rule, to understand how to add a new rule. Look at the source files in the 'src' directory, particularly 'rules/' to see pattern matching on AST nodes. The issue requests a rule that transforms 'if not' or 'if !' conditions to 'unless' when there is no else clause. The implementation likely involves checking the AST for 'If' nodes and then suggesting the replacement.