clutchski/coffeelint

add rule that if(!foo) should be replaced with unless

Open

#381 opened on Feb 18, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)CoffeeScript (169 forks)batch import
Help Wantednew rule

Repository metrics

Stars
 (1,203 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

basically - if you have an if block with no else, and you have if not or if !blah, it should be replaced with unless.

if !user
    return res.badRequest ...

should become

unless user
    return res.badRequest..

Contributor guide

Research direction
Examine existing rule implementations in coffeelint to understand the pattern for adding a new rule. Write a rule that detects `if` with `!` or `not` and suggests `unless`.
Tech stack
None
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCoffeeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60