clutchski/coffeelint

catch "if" statement with single "="

Open

#355 opened on Nov 27, 2014

View on GitHub
 (3 comments) (1 reaction) (0 assignees)CoffeeScript (169 forks)batch import
Help Wantednew rule

Repository metrics

Stars
 (1,203 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

How about catching the mistake that I make most often? An "if" statement that uses a single "=" instead of double "==" compiles just fine, but causes confusing behaviour at runtime. I wish my editor would warn me when I do this. Example:

if a = b
    do_something()

Contributor guide

Research direction
Examine existing lint rules in coffeelint source code, such as 'no debugger' or 'no tabs', and create a new rule that detects assignment (=) instead of comparison (== or ===) in if conditions.
Tech stack
None
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CoffeeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75