clutchski/coffeelint

catch "if" statement with single "="

Open

#355 opened on Nov 27, 2014

View on GitHub
 (3 comments) (1 reaction) (0 assignees)CoffeeScript (1,203 stars) (169 forks)batch import
Help Wantednew rule

Description

How about catching the mistake that I make most often? An "if" statement that uses a single "=" instead of double "==" compiles just fine, but causes confusing behaviour at runtime. I wish my editor would warn me when I do this. Example:

if a = b
    do_something()

Contributor guide

Tech stack
None
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CoffeeScript syntaxcoffeelint rule APItest writing basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine existing rules in 'src/rules/' to understand the pattern for adding a new rule. Implement a rule that triggers when '=' is used in an 'if' condition instead of '=='. Add tests in 'test/' following existing conventions and ensure the rule is registered in the linter's configuration.
catch "if" statement with single "=" · clutchski/coffeelint#355 | Good First Issue