cloudtools/troposphere

Add ScheduleExpression validation

Open

#1,052 opened on May 24, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (4,865 stars) (1,487 forks)batch import
enhancementhelp wanted

Description

The field troposphere.events.Rule::ScheduleExpression is a basestring. The validity of it is confirmed during the stack creation of CloudWatch. The documentation for that field can be found here.

Would it be possible to validate the cron when JSON is being generated?

Contributor guide

Tech stack
python
Domain
backendcloud
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
pythonregextroposphere internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Add validation for ScheduleExpression in troposphere/events.py, likely by subclassing a property type that checks the cron or rate pattern. Look at existing custom property validations in troposphere for reference, such as the 'validators' module. The cron expression format is documented in the AWS CloudWatch Events link provided in the issue.
Add ScheduleExpression validation · cloudtools/troposphere#1052 | Good First Issue