cloudtools/stacker

When specifying the tags TLK, stacker removes the stacker_namespace tag

Open

#496 opened on Oct 18, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (166 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (706 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is more of a bother than a real issue. When a stacker config yaml has tags defined, it removes the default stacker_namespace tag. This is not necessarily the expected behavior.

https://github.com/remind101/stacker/blob/ecd8933d715da8ede5b0d6e6d1e98bd827ff6b43/stacker/context.py#L97

When tackling this issue, we have to be cautious of end-users who have workarounds in place to add the stacker_namespace tag back in via the yaml config. Stacker should not crash in this scenario.

Contributor guide

Research direction
Examine the code at stacker/context.py line 97 to understand how tags are processed and ensure the stacker namespace tag is not removed when custom tags are specified. Also check existing tests and any workarounds to avoid breaking changes.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80