cloudpipe/cloudpickle

0.8.0 3 tests fail

Open

#252 opened on Mar 7, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Python (1,407 stars) (152 forks)batch import
bughelp wanted

Description

When building cloudpickle 0.8.0 package for openSUSE I have 3 test failures:

[   10s] =================================== FAILURES ===================================
[   10s] ___________ CloudPickleFileTests.test_pickling_special_file_handles ____________
[   10s] 
[   10s] self = <tests.cloudpickle_file_test.CloudPickleFileTests testMethod=test_pickling_special_file_handles>
[   10s] 
[   10s]     def test_pickling_special_file_handles(self):
[   10s]         # Warning: if you want to run your tests with nose, add -s option
[   10s]         for out in sys.stdout, sys.stderr:  # Regression test for SPARK-3415
[   10s] >           self.assertEqual(out, pickle.loads(cloudpickle.dumps(out)))
[   10s] E           AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb6d0> != <_pytest.capture.EncodedFile object at 0x7fc4981be990>
[   10s] 
[   10s] tests/cloudpickle_file_test.py:98: AssertionError
[   10s] __________________ CloudPickleTest.test_pickling_file_handles __________________
[   10s] 
[   10s] self = <tests.cloudpickle_test.CloudPickleTest testMethod=test_pickling_file_handles>
[   10s] 
[   10s]     def test_pickling_file_handles(self):
[   10s]         out1 = sys.stderr
[   10s]         out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[   10s] >       self.assertEqual(out1, out2)
[   10s] E       AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa0ef150>
[   10s] 
[   10s] tests/cloudpickle_test.py:119: AssertionError
[   10s] _____________ Protocol2CloudPickleTest.test_pickling_file_handles ______________
[   10s] 
[   10s] self = <tests.cloudpickle_test.Protocol2CloudPickleTest testMethod=test_pickling_file_handles>
[   10s] 
[   10s]     def test_pickling_file_handles(self):
[   10s]         out1 = sys.stderr
[   10s]         out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[   10s] >       self.assertEqual(out1, out2)
[   10s] E       AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa179ed0>
[   10s] 
[   10s] tests/cloudpickle_test.py:119: AssertionError

0.7.0 didn't have any issues with these tests. Full build log: cloudpickle.txt

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Pythonpytestunderstanding of pickle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The test failure occurs because pytest replaces sys.stdout and sys.stderr with custom EncodedFile objects during test execution. The tests compare the original and unpickled objects using equality, which fails because the objects are different instances. The fix may involve modifying the test to check for functional equivalence rather than identity, or using a context manager to restore original streams. Look at the test files tests/cloudpickle file test.py and tests/cloudpickle test.py, and consider reviewing the pytest capture mechanism.