cloudflare/vinext

Build: transitive externals resolve to wrong package version

Open

#1,503 opened on May 22, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (329 forks)github user discovery
adapter-api-e2ehelp wanted

Repository metrics

Stars
 (8,120 stars)
PR merge metrics
 (Avg merge 1d 1h) (462 merged PRs in 30d)

Description

This issue was created by an agent analysing CI failures from the Next.js Deploy Suite (vinext main vs Next.js v16.2.6, 2026-05-22).

Problem

When serverExternalPackages (or equivalent) is configured, transitive dependencies resolve to the wrong version. Test expects depB: 4.17.21, 4.17.21, 5.0.0 but got depB: 3.10.1, 4.17.21, 5.0.0 — the first depB instance is wrongly resolved to depA's version.

Transitive externals resolution picks wrong package version

Estimated Impact

~1 test failures across the deploy suite.

Affected Test Suites

  • test/e2e/externals-transitive/externals-transitive.test.ts

Recommendation

  1. Reproduce first in vinext's own test suite. Add a fixture with depA -> depB@4 and root -> depB@3, mark depA as external, and assert each module sees the correct depB version.

  2. Preserve transitive version resolution. Externalising a package must not collapse nested copies of a transitive dep to a single version.

Contributor guide

Research direction
Examine the test fixture in `test/e2e/externals transitive/` to understand the dependency graph (depA > depB@4, root > depB@3). Trace the module resolution logic in the vite plugin to find where transitive externals collapse nested copies.
Tech stack
typescriptnodejs
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50