cloudflare/pingora

Pingora-core L4 listen fail(windows)

Open

#468 opened on Nov 12, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Rust (26,634 stars) (1,642 forks)batch import
bughelp wanted

Description

Describe the bug

Pingora-core L4 listen fail: cannot find value listen_addr in this scope.

 #[cfg(windows)]
    pub async fn listen(self) -> Result<ListenerEndpoint> {
        Ok(ListenerEndpoint {
            listen_addr,
            listener: bind(&listen_addr).await?,
        })
    }

https://github.com/cloudflare/pingora/blob/main/pingora-core/src/listeners/l4.rs#L308

Pingora info

Please include the following information about your environment:

Pingora version: bdb13a7e40b19280d703ad1f64abc29ee5baf480 Rust version: cargo 1.82.0 Operating system version: e.g. Ubuntu 22.04, Debian 12.4

Steps to reproduce

Please provide step-by-step instructions to reproduce the issue. Include any relevant code snippets.

Expected results

What were you expecting to happen?

Observed results

What actually happened?

Additional context

What other information would you like to provide? e.g. screenshots, how you're working around the issue, or other clues you think could be helpful to identify the root cause.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsunderstanding of conditional compilation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug is in `pingora core/src/listeners/l4.rs` at line 308, where the Windows specific `listen` function tries to return `listen addr` which is not defined. The fix likely involves either passing `listen addr` as a parameter or recreating the socket address from the listener. Look at the Unix implementation for reference.