clawwork-ai/ClawWork

[Bug] Race condition in task-store hydrate with cachedDeviceId

Open

#239 opened on Apr 1, 2026

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (63 forks)github user discovery
area/coregood first issue

Repository metrics

Stars
 (519 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem

Module-level mutable variable cachedDeviceId creates a race condition when hydrate() is called concurrently. Multiple calls can overwrite each other's state.

Location

File: packages/core/src/stores/task-store.ts:95

Code:

let cachedDeviceId: string | null = null;

// In hydrate():
if (get().hydrated) return;
cachedDeviceId = await deps.getDeviceId();

Fix Approach

Use a hydration promise to ensure single execution:

let hydrationPromise: Promise<void> | null = null;

// In hydrate:
if (get().hydrated) return;
if (hydrationPromise) return hydrationPromise;

hydrationPromise = (async () => {
  cachedDeviceId = await deps.getDeviceId();
  // ... rest of hydration
})();

return hydrationPromise;

Or move cachedDeviceId into store state.

Verification

  1. Run pnpm check — must pass
  2. Test concurrent hydrate calls don't race

Context

  • WG: Task & Session Core
  • Priority: Low (good first issue)
  • Estimated effort: 15-30 minutes

Contributor guide

Research direction
Implement the proposed fix by adding a hydration promise to prevent concurrent hydration calls from overwriting each other, or move `cachedDeviceId` into the store state. Verify with `pnpm check` and test concurrent calls.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85