claviska/jquery-minicolors

Swatch isn't selected when minicolors inits and input has a swatch color value

Open

#256 opened on Aug 16, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (955 stars) (322 forks)batch import
BugHelp Wanted

Description

Steps to reproduce:

On an input field with a value of a color of a swatch, init the minicolors plugin. If you open minicolors you can see the swatch color isn't selected (if you type another value it is then selected)

This happens because on init updateFromInput is called and that doesn't do the logic of selecting the swatch instead it calls doChange but only when minicolors is initialized:

// Fire change event, but only if minicolors is fully initialized
    if(input.data('minicolors-initialized')) {
      doChange(input, value, opacity);
    }

I'm not sure why doChange isn't called always, if it's just for performance issue or if it's to fix some bugs but I see 2 possible solutions: add swatch selection logic to init or updateFromInput or always call doChange even if minicolors is initialiazing.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptjQueryUnderstanding of minicolors plugin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is that the swatch color is not selected on initialization when the input has a matching color value. The bug is in the 'updateFromInput' function which conditionally calls 'doChange' only after initialization, skipping swatch selection logic. Look at the code around line where 'input.data('minicolors initialized')' is checked. Consider two approaches: either add swatch selection logic to 'updateFromInput' or always call 'doChange' during init. The fix is likely small and localized to that function.
Swatch isn't selected when minicolors inits and input has a swatch color value · claviska/jquery-minicolors#256 | Good First Issue