claviska/jquery-minicolors

Top position is off when using 'position: top' with swatches

Open

#236 opened on Nov 23, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (955 stars) (322 forks)batch import
BugHelp Wanted

Description

When you use minicolors with swatches, combined with position: 'top left' or position:'top right', the colorpicker panel is positioned incorrectly, it overlays the input box. minicolors1 minicolors2

I've made the following fix in jquery.minicolor.js, starting at line 212:

    // Swatches
    if(settings.swatches && settings.swatches.length !== 0) {
      if (/top/.test(settings.position)) {
         var nrRows = Math.ceil(settings.swatches.length / 7);
         panel.css('top', (nrRows == 1 ? -182 : -204)+'px');
      }
      panel.addClass('minicolors-with-swatches');
      ....

Variable nrRows contains the number of rows of swatches (either 1 or 2), and the top position is changed accordingly. This fixes it for me. Hopefully you can apply this (or a similar) fix. Thanks, keep up the good work!

Contributor guide

Tech stack
javascriptcsshtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic jQuery knowledgeCSS positioning
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the file jquery.minicolors.js around line 212. The issue reports that the top position of the colorpicker panel is incorrect when swatches are enabled and position is set to 'top left' or 'top right'. The user suggests adjusting the panel's 'top' CSS property based on the number of swatch rows. Confirm the current behavior, review the swatches section, and implement a similar fix that accounts for dynamic row count.