claimed-framework/mlx

Add server stand up test as part of MLX CI

Open

#213 opened on Sep 15, 2021

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)Python (54 forks)github user discovery
APIhelp wantedsize/Stest

Repository metrics

Stars
 (218 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi @ckadner sorry I didn't have time to recompile the server for every PR. Right now our CI is only catching build errors but we don't have any test to catch runtime errors. Maybe we can add a simple test just to start the server to make sure nothing is crashing the server startup? This way we don't accidentally merged critical bugs that crashes our server startup.

Originally posted by @Tomcli in https://github.com/machine-learning-exchange/mlx/issues/205#issuecomment-920338732

Contributor guide

Research direction
Identify the server startup script or command, create a minimal test that executes it and verifies successful start, and integrate into CI.
Tech stack
python
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75