clab/dynet

Concatenate batch fails if vectors are of sizes (dim,) and (dim, 1)

Open

#531 opened on May 8, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (701 forks)github user discovery
good first issuemoderate bug

Repository metrics

Stars
 (3,433 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi! The title sums it up. If you try to concatenate d-dimensional vectors but some vectors' shape is (d,) while others is (d, 1), dynet.concatenate_batch fails. However, if you do dynet.concatenate_cols and then a reshape, everything works fine.

Contributor guide

Research direction
Investigate the concatenate batch implementation to understand why it rejects shape mismatches between (dim,) and (dim,1) while concatenate cols works. Trace the code path and identify the shape check that fails.
Tech stack
python
Domain
backendai
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70