citadel-tech/coinswap

Password handler refactor

Open

#956 opened on Jul 27, 2026

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Rust (132 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (159 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

In load_sensitive_struct, in the case of a None password, if parsing fails we ask the user to enter the password utill::prompt_password("Enter encryption passphrase: ".to_string())?, which is irrelevant to this API — it's a terminal I/O operation that doesn't belong in a decrypt helper and should be handled by the caller if the parse fails.

Contributor guide

Research direction
Locate the `load sensitive struct` function, remove the `prompt password` call, and ensure the caller handles the None password case appropriately.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70