chroma-core/chroma

Make Jest testing code more idiomatic

Open

#2801 opened on Sep 16, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (27,958 stars) (2,247 forks)batch import
by-chromagood first issue

Description

There are places where we can improve the quality of our Jest tests as https://github.com/chroma-core/chroma/pull/2135 points out. This does not affect correctness but it does make our tests more idiomatic Jest.

I closed the above PR since the diff was considerably large.

Contributor guide

Tech stack
jestjavascript
Domain
testingdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Jestbasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the closed PR #2135 for examples of idiomatic Jest patterns. Examine existing test files in the repository to identify non idiomatic usage. Follow Jest documentation for best practices like using `toBe` vs `toEqual`, avoiding `expect.extend` misuse, and proper mocking patterns. Focus on making test assertions and setup more concise and readable.