chroma-core/chroma

Enable mypy lint in CI

Open

#2,054 opened on Apr 24, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (2,247 forks)batch import
by-chromacleanupgood first issue

Repository metrics

Stars
 (27,958 stars)
PR merge metrics
 (Avg merge 1d 16h) (80 merged PRs in 30d)

Description

I recently enabled most of our lints in CI: https://github.com/chroma-core/chroma/pull/2046.

I didn't enable mypy in that PR because it looked like it required a few manual changes to pass the lint. We need to enable this lint by updating .github/workflows/chroma-lint.yml and making the appropriate changes to pass the lint (test locally with pre-commit run --all-files mypy).

Contributor guide

Research direction
Update .github/workflows/chroma lint.yml to add mypy, then run pre commit run all files mypy locally to fix lint errors.
Tech stack
python
Domain
ci cd
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGitCI/CD
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70