chroma-core/chroma

Enable mypy lint in CI

Open

#2054 opened on Apr 24, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (27,958 stars) (2,247 forks)batch import
by-chromacleanupgood first issue

Description

I recently enabled most of our lints in CI: https://github.com/chroma-core/chroma/pull/2046.

I didn't enable mypy in that PR because it looked like it required a few manual changes to pass the lint. We need to enable this lint by updating .github/workflows/chroma-lint.yml and making the appropriate changes to pass the lint (test locally with pre-commit run --all-files mypy).

Contributor guide

Tech stack
pythongithub actions
Domain
ci cddeveloper experience
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonmypyGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is to enable mypy linting in CI by updating `.github/workflows/chroma lint.yml`. The previous PR #2046 enabled other lints. To complete this, run `pre commit run all files mypy` locally to see and fix the mypy errors. Then modify the workflow file to include mypy. The changes are likely straightforward but require understanding of Python type annotations and mypy configuration.